Skip to content

Add endpoint to fetch submissions by internal ID for domlogo #3002

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add endpoint to fetch submissions by internal ID for domlogo #3002

wants to merge 1 commit into from

Conversation

nickygerritsen
Copy link
Member

No description provided.

@nickygerritsen nickygerritsen requested a review from meisterT May 23, 2025 20:56
@nickygerritsen
Copy link
Member Author

The other alternatives are:

  • Add an endpoint that converts the external submission ID to the internal submission ID.
  • Add the internal submission ID to the Working directory: line in the judgedaemon.

@vmcj
Copy link
Member

vmcj commented May 24, 2025

Why do we actually get this problem? I would prefer not exposing our "internal" id anywhere.

So I think option1 is better, or making sure our internal ID is also the external ID, to remove such doublings.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@meisterT meisterT Awaiting requested review from meisterT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickygerritsen @vmcj